Add Srpski (Cyrillic) #3860
Add Srpski (Cyrillic) #3860
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🥷 Code experts: Jack251970 Jack251970 has most 🧠 knowledge in the files. See details
Knowledge based on git-blame: ✨ Comment |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdded a Serbian Cyrillic language variant ("sr-Cyrl-RS") to available languages and updated system translation mappings to distinguish Serbian Latin ("sr") from Serbian Cyrillic ("sr-Cyrl-RS"), changing "sr" translation and adding an entry for "sr-Cyrl-RS". Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AvailableLanguages
User->>AvailableLanguages: GetAvailableLanguages()
AvailableLanguages-->>User: List includes Serbian_Cyrillic ("sr-Cyrl-RS")
User->>AvailableLanguages: GetSystemTranslation("sr")
AvailableLanguages-->>User: "Sistem"
User->>AvailableLanguages: GetSystemTranslation("sr-Cyrl-RS")
AvailableLanguages-->>User: "Систем"
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Flow.Launcher.Core/Resource/AvailableLanguages.cs(3 hunks)
🧠 Learnings (1)
Flow.Launcher.Core/Resource/AvailableLanguages.cs (2)
Learnt from: taooceros
PR: #2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In the Flow Launcher project, the version number in the Flow.Launcher.csproj file is dynamically updated during the CI/CD process.
Learnt from: Jack251970
PR: #3850
File: Flow.Launcher.Core/Resource/Internationalization.cs:0-0
Timestamp: 2025-07-20T07:28:28.092Z
Learning: In Flow Launcher's Internationalization class, when the Flow Launcher language directory or default language file is missing, the only viable approach is to log an error and return early - there are no fallback mechanisms or alternative recovery strategies available due to architectural constraints.
🧰 Additional context used
🧠 Learnings (1)
Flow.Launcher.Core/Resource/AvailableLanguages.cs (2)
Learnt from: taooceros
PR: #2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In the Flow Launcher project, the version number in the Flow.Launcher.csproj file is dynamically updated during the CI/CD process.
Learnt from: Jack251970
PR: #3850
File: Flow.Launcher.Core/Resource/Internationalization.cs:0-0
Timestamp: 2025-07-20T07:28:28.092Z
Learning: In Flow Launcher's Internationalization class, when the Flow Launcher language directory or default language file is missing, the only viable approach is to log an error and return early - there are no fallback mechanisms or alternative recovery strategies available due to architectural constraints.
🔇 Additional comments (2)
Flow.Launcher.Core/Resource/AvailableLanguages.cs (2)
20-20: LGTM! Proper BCP 47 language code and Cyrillic display name.The Serbian Cyrillic language definition follows the correct BCP 47 standard ("sr-Cyrl-RS") and uses the appropriate Cyrillic script display name "Српска".
51-51: LGTM! Correctly added to the available languages list.The Serbian_Cyrillic language is properly added to the list in a logical position after the existing Serbian entry.
oh sorry I think so. I misunderstand it before. |
Co-authored-by: Copilot <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@Jack251970 @taooceros not sure if the low confidence suggestion from Copilot needs addressing. |
I think so. 
Changed as request |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Serbian Cyrillic as a separate language option in Flow Launcher, distinguishing it from the existing Serbian Latin variant.
- Adds Serbian Cyrillic language definition with appropriate locale code and native name
- Updates the translation system to distinguish between Serbian Latin and Cyrillic variants
- Corrects the existing Serbian entry to use Latin script representation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Flow.Launcher.Core/Resource/AvailableLanguages.cs (1)
84-85: System translation: Latin vs. Cyrillic split is correct; consider adding common alias tags and silence the spell-check warning
- "sr" => "Sistem" (Latin) and "sr-Cyrl-RS" => "Систем" (Cyrillic) is correct and aligns with your autonyms.
- For robustness with OS/culture codes, consider handling additional aliases frequently seen in the wild (sr-Latn, sr-Latn-RS, sr-Cyrl). This avoids falling back to the default "System" when those tags are encountered.
Apply this diff to add aliases:
- "sr" => "Sistem", - "sr-Cyrl-RS" => "Систем", + "sr" => "Sistem", + "sr-Latn" => "Sistem", + "sr-Latn-RS" => "Sistem", + "sr-Cyrl" => "Систем", + "sr-Cyrl-RS" => "Систем",Nit: The spell-check warning on "Sistem" is a false positive; it is the correct Serbian (Latin) spelling. If your CI uses a spell checker, add "Sistem" to its allowlist to silence the warning.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Flow.Launcher.Core/Resource/AvailableLanguages.cs(3 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
Flow.Launcher.Core/Resource/AvailableLanguages.cs (1)
Flow.Launcher.Core/Resource/Internationalization.cs (1)
Language(171-184)
🪛 GitHub Check: Check Spelling
Flow.Launcher.Core/Resource/AvailableLanguages.cs
[warning] 84-84:
Sistem is not a recognized word. (unrecognized-spelling)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: gitStream.cm
- GitHub Check: build
🔇 Additional comments (2)
Flow.Launcher.Core/Resource/AvailableLanguages.cs (2)
51-51: Included in GetAvailableLanguages — LGTMThe new Serbian (Cyrillic) variant is correctly added to the returned list and positioned next to Serbian (Latin).
20-20: Serbian (Cyrillic) resource coverage and fallbackNo dedicated
sr-Cyrl-RSresource files were found; by default, the runtime will fall back to the neutralsrpack (e.g.Flow.Launcher/Languages/sr.xamland all*/Languages/sr.xamlin plugins). Please verify:
- That the existing
sr.xamltranslations are in Cyrillic so users don’t see Latin text when selecting “Српски”.- If they’re not Cyrillic, add
sr-Cyrl-RS-named resource files (or aliassr-Cyrl-RS→srafter converting to Cyrillic).- The fallback chain (
sr-Cyrl-RS→sr→ default) behaves as intended.Also note in
AvailableLanguages.cs(around line 85) you map"sr-Cyrl-RS"to"Систем"inGetSystemTranslation. Ensure that aligns with the rest of the pack.
No description provided.